Skip to content

ci: Add Varnish caching service to Docker Compose setup#36025

Draft
ggazzo wants to merge 11 commits intodevelopfrom
ci/cache
Draft

ci: Add Varnish caching service to Docker Compose setup#36025
ggazzo wants to merge 11 commits intodevelopfrom
ci/cache

Conversation

@ggazzo
Copy link
Copy Markdown
Member

@ggazzo ggazzo commented May 19, 2025

  • Introduced a new Varnish service with configuration for caching static assets and handling specific request types.
  • Updated Rocket.Chat service to depend on Varnish and added necessary Traefik labels for routing.
  • Created default VCL configuration for Varnish to manage caching behavior.

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@ggazzo
feat: Add Varnish caching service to Docker Compose setup
51c8023 
- Introduced a new Varnish service with configuration for caching static assets and handling specific request types.
- Updated Rocket.Chat service to depend on Varnish and added necessary Traefik labels for routing.
- Created default VCL configuration for Varnish to manage caching behavior.
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot Bot commented May 19, 2025 •
edited
Loading

Looks like this PR is not ready to merge, because of the following issues:

  • This PR has conflicts, please resolve them before merging
  • This PR is missing the 'stat: QA assured' label
  • This PR is not mergeable
  • This PR is targeting the wrong base branch. It should target 8.5.0, but it targets 8.4.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 19, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 972b09e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.66%. Comparing base (4a19aaa) to head (972b09e).
⚠️ Report is 1595 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36025      +/-   ##
===========================================
- Coverage    64.74%   64.66%   -0.08%     
===========================================
  Files         3156     3306     +150     
  Lines       104916   108072    +3156     
  Branches     19960    20315     +355     
===========================================
+ Hits         67929    69889    +1960     
- Misses       34298    35353    +1055     
- Partials      2689     2830     +141
Flag Coverage Δ
e2e 57.57% <ø> (ø)
unit 69.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2025 •
edited
Loading

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36025/

Built to branch gh-pages at 2025-07-09 12:23 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

ggazzo and others added 10 commits May 19, 2025 15:03
@ggazzo
chore: Remove Varnish service dependencies from Docker Compose config…
8eb3e75 
…uration

- Eliminated Varnish service dependency from Rocket.Chat and removed related configuration in the Docker Compose file.
- Adjusted service labels for Traefik routing accordingly.
@ggazzo
fix: Update Traefik routing rules for Rocket.Chat and Varnish services
6858e84 
- Changed Rocket.Chat routing rule to use PathPrefix(`/sockjs`).
- Modified Varnish routing rule to exclude paths for `/sockjs` and `/websocket`.
- Adjusted Varnish VCL configuration to handle WebSocket connections with `pipe` instead of `pass`.
@ggazzo
fix: Update Traefik routing rules to include health check path
1262ce9 
- Modified Rocket.Chat routing rule to allow health check path alongside `/sockjs`.
- Updated Varnish routing rule to exclude health check path from its routing logic.
@ggazzo
chore: Update Docker Compose configuration to include app network and…
9bf520b 
… Varnish dependency

- Added `app-network` to the Docker Compose file for service communication.
- Updated Rocket.Chat service to depend on Varnish for improved caching and routing.
@ggazzo
..
70c2602
@ggazzo
..
47750b6
@ggazzo
..
a0db4d8
@ggazzo
..
c6ad3a0
@ggazzo
Merge branch 'develop' into ci/cache
f426af8
@ggazzo
Merge branch 'develop' into ci/cache
972b09e
@ggazzo ggazzo modified the milestones: 8.4.0, 8.5.0 Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

stat: conflict

Projects

None yet

Milestone

8.5.0

Development

Successfully merging this pull request may close these issues.

1 participant

@ggazzo